Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Migration Testing CI Step #3900

Closed
bryanculver opened this issue Jun 12, 2023 · 1 comment · Fixed by #3960
Closed

Add Migration Testing CI Step #3900

bryanculver opened this issue Jun 12, 2023 · 1 comment · Fixed by #3960
Assignees
@glennmatthews
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

Proposed Changes

  • Introduce a CI step to start from a database snapshot and perform the migrations included in the branch/PR and perform nautobot-server migrate. Step/check passes if the migrations run without error.

  • Stretch to get this to work locally

Justification

Existing migration tests are flaky and aren't capturing errors like #3889 without sufficient rework. This test would more realistically test what users are expected to experience.
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 12, 2023
@glennmatthews glennmatthews added this to the v2.0.0 milestone Jun 12, 2023
@glennmatthews glennmatthews self-assigned this Jun 20, 2023
This was referenced Jun 20, 2023
Merged
Merged
@glennmatthews glennmatthews linked a pull request Jun 21, 2023 that will close this issue
Implement 'migration-test' task, add test dataset for postgres, add CI step #3960
Merged
7 tasks
@glennmatthews
Copy link
Contributor

Implemented by #3960.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Implement 'migration-test' task, add test dataset for postgres, add CI step nautobot/nautobot
2 participants
@bryanculver @glennmatthews