Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device name copy button adding an extra space/return #3948

Merged
merged 3 commits into from Jun 20, 2023

Conversation

u1735067
Copy link
Contributor

@u1735067 u1735067 commented Jun 19, 2023

Closes:

What's Changed

This fixes the device name copy button that adds an extra space (chrome) or return (firefox) to the copied text, by enclosing the device name in a span that now use the devicename id (instead of the h1)

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

This fixes the device name copy button that adds an extra space (chrome) or return (firefox) to the copied text, by enclosing the device name in a span that now use the `devicename` id (instead of the h1)
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Would you mind adding a changes/3948.fixed file that documents this fix for the changelog?

@u1735067
Copy link
Contributor Author

Thanks for the pull request! Would you mind adding a changes/3948.fixed file that documents this fix for the changelog?

Sure, done, I wasn't sure how to handle that without a proper issue.

@glennmatthews glennmatthews merged commit ec1a8d8 into nautobot:develop Jun 20, 2023
17 checks passed
@u1735067 u1735067 deleted the patch-1 branch July 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants