Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user that created and last updated object in advanced tab #3994

Closed
12 tasks
lampwins opened this issue Jun 26, 2023 · 5 comments
Closed
12 tasks

Show user that created and last updated object in advanced tab #3994

lampwins opened this issue Jun 26, 2023 · 5 comments
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@lampwins
Copy link
Member

lampwins commented Jun 26, 2023

As ...

Dan - Data Owner

I want ...

I easily see at a glance the user that created and last updated an object in nautobot

So that ...

I can quickly audit this important detail without having to go to the changelog

I know this is done when...

  • The user name that created and last updated the object are shown in the advanced tab
  • If the user name for the object in either case is not know, simple show an em dash
  • The advanced tab should show this data in a new "Data Provenance" section

Optional - Feature groups this request pertains to.

  • Automation
  • Circuits
  • DCIM
  • IPAM
  • Misc (including Data Sources)
  • Organization
  • Plugins (and other Extensibility)
  • Security (Secrets, etc)
  • Image Management
  • UI/UX
  • Documentation
  • Other (not directly a platform feature)

Database Changes

No response

External Dependencies

No response

@lampwins lampwins added the type: feature Introduction of new or enhanced functionality to the application label Jun 26, 2023
@bryanculver
Copy link
Member

The quickest way to address this would be to look up the first and most recent ObjectChange record but those may have been cleaned up, especially the first.

Should we add a created_by, changed_by (and do similar username caching we do for ObjectChange in the event of a deleted user) to `ChangeLoggedModel?

What is the "user" if we don't have historical information?

What is the "user" in the direct ORM change case?

@lampwins
Copy link
Member Author

lampwins commented Oct 2, 2023

@bryanculver
Copy link
Member

The quickest way to address this would be to look up the first and most recent ObjectChange record but those may have been cleaned up, especially the first.

Should we add a created_by, changed_by (and do similar username caching we do for ObjectChange in the event of a deleted user) to ChangeLoggedModel? This should "Just Work :tm:" with ChangeLoggedModel` (app developers shoudln't be required to add migrations)

Either attempt performant indexing of the ObjectChange records or use Redis caching

What is the "user" if we don't have historical information?

Do not show or em-dash.

What is the "user" in the direct ORM change case?

Outside of scope.

@gsnider2195
Copy link
Contributor

Also needs to be presented in the API for new UI to display

@bryanculver
Copy link
Member

Also needs to be presented in the API for new UI to display

Does not need to be. We can make a separate API call to get this data.

@HanlinMiao HanlinMiao self-assigned this Oct 24, 2023
@lampwins lampwins added this to the v2.1 milestone Dec 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants