Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb rendering in new UI #3998

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

glennmatthews
Copy link
Contributor

@glennmatthews glennmatthews commented Jun 26, 2023

Closes: #n/a

What's Changed

Fix incorrect data reference in GenericView code that was causing breadcrumbs never to render correctly and always fall back to just displaying "Home". I think this is an alternative solution to #3957 and more preferable.

Before:

image

After:

image

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • n/a Unit, Integration Tests
  • n/a Documentation Updates (when adding/changing features)
  • n/a Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Jun 26, 2023
@glennmatthews glennmatthews self-assigned this Jun 26, 2023
@glennmatthews glennmatthews merged commit c79a179 into next Jun 27, 2023
21 checks passed
@glennmatthews glennmatthews deleted the u/glennmatthews-ui-2.0-fix-breadcrumbs branch June 27, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants