Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve New UI Rebuild Performance #4083

Closed
bryanculver opened this issue Jul 10, 2023 · 5 comments · Fixed by #4214
Closed

Improve New UI Rebuild Performance #4083

bryanculver opened this issue Jul 10, 2023 · 5 comments · Fixed by #4214
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@bryanculver
Copy link
Member

Proposed Changes

Either:

This is a time-boxed story: If we can't reasonably do option one in the time permitted, switch to option two as a stop-gap and we can revisit option one in a fast follow-up.

Justification

The developer side and app start-up are slow because every post_upgrade is doing a full rebuild of the UI, even if things are unchanged. In 2.0.0 there won't really be anything to rebuild.

@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jul 10, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Jul 10, 2023
@gsnider2195
Copy link
Contributor

Create React App appears to be dead.

@bryanculver
Copy link
Member Author

@timizuoebideri1 timizuoebideri1 self-assigned this Aug 2, 2023
@glennmatthews glennmatthews linked a pull request Aug 4, 2023 that will close this issue
7 tasks
@gsnider2195
Copy link
Contributor

Potential path forward (next.js with react-router): Building a single-page application with Next.js and React Router

Links to Replacing Create React App with the Next.js CLI

@bryanculver
Copy link
Member Author

Today:

We have #4214 but requires more time to review and document which parts are coming in from ejecting and which parts are overridden by us (because of CRACO/other overrides). We will commit time to review the PR (2 story points), ensure it has proper documentation, and move forward with that approach.

Future Story:

We can eject and own our build tools (build) vs find a replacement for Create React App (buy).

To quote @jathanism:

We bought something and the company went out of business.

We need to figure out what we're taking on with either approach:

Build: We accept an amount of tech debt and knowledge and understanding on how to continue building what we need with the tools and dependencies we have (or evolving them).

Buy: Find a replacement of CRA/CRACO that offloads a larger amount of the maintenance of the tools for a client-side app to reduce the overhead.

@glennmatthews
Copy link
Contributor

Implemented by #4214.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants