-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve New UI Rebuild Performance #4083
Comments
Ejecting documentation: https://create-react-app.dev/docs/available-scripts/#npm-run-eject |
Potential path forward (next.js with react-router): Building a single-page application with Next.js and React Router |
Today:We have #4214 but requires more time to review and document which parts are coming in from ejecting and which parts are overridden by us (because of CRACO/other overrides). We will commit time to review the PR (2 story points), ensure it has proper documentation, and move forward with that approach. Future Story:We can eject and own our build tools (build) vs find a replacement for Create React App (buy). To quote @jathanism:
We need to figure out what we're taking on with either approach: Build: We accept an amount of tech debt and knowledge and understanding on how to continue building what we need with the tools and dependencies we have (or evolving them). Buy: Find a replacement of CRA/CRACO that offloads a larger amount of the maintenance of the tools for a client-side app to reduce the overhead. |
Implemented by #4214. |
Proposed Changes
Either:
This is a time-boxed story: If we can't reasonably do option one in the time permitted, switch to option two as a stop-gap and we can revisit option one in a fast follow-up.
Justification
The developer side and app start-up are slow because every
post_upgrade
is doing a full rebuild of the UI, even if things are unchanged. In 2.0.0 there won't really be anything to rebuild.The text was updated successfully, but these errors were encountered: