Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Enable python 3.11, update dependencies to match #4118 #4125

Merged
merged 2 commits into from Jul 17, 2023

Conversation

glennmatthews
Copy link
Contributor

Closes: #n/a

What's Changed

Counterpart to #4118. The subset of that PR (since #3027/#3554/#3674 are already in next) needed to enable python 3.11 and update remaining dependencies to the same versions as in #4118. Doing this to try to head off merge conflicts once we get around to bringing the 1.6 content up into 2.0.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • n/a Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@glennmatthews glennmatthews requested a review from a team July 14, 2023 17:08
@glennmatthews glennmatthews self-assigned this Jul 17, 2023
Copy link
Contributor

@HanlinMiao HanlinMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -2,7 +2,7 @@

Nautobot is packaged as a Docker image for use in a production environment. The published image is based on the `python:3.8-slim` image to maintain the most compatibility with Nautobot deployments. The Docker image and deployment strategies are being actively developed, check back here or join the **#nautobot** channel on [Network to Code's Slack community](https://slack.networktocode.com/) for the most up to date information.

+/- 2.0.0
+/- 1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.6 if it is based off of next?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same question throughout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made these changes because of #4118 - given that 1.6 is also dropping 3.7 and adding 3.11, saying this is new in 2.0 wouldn't really be accurate any more. Credit where credit is due, that sort of thing.

@glennmatthews glennmatthews merged commit 52bbbf8 into next Jul 17, 2023
23 checks passed
@glennmatthews glennmatthews deleted the u/glennmatthews-next-add-python311 branch July 17, 2023 20:05
@bryanculver bryanculver added this to the v1.6.0 milestone Jul 31, 2023
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants