Adds documentation on power utilization #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timizuoebideri1
approved these changes
Aug 1, 2023
Comment on lines
-19
to
-21
|
|
||
| !!! info | ||
| The power utilization of a rack is calculated when one or more power feeds are assigned to the rack and connected to devices that draw power. |
There was a problem hiding this comment.
Why remove this? Is it inaccurate?
There was a problem hiding this comment.
It became the opening line in the new Rack Power Utilization section in power.md. Since powerfeed.md was only imported in that one place it seemed redundant. I, essentially, upgraded it from a note to its own section on the main page.
There was a problem hiding this comment.
Ah okay. My only hesitation there would be that powerfeed.md is also displayed standalone when you're editing a PowerFeed record in the UI and click the (?) button, this note will be missing there, but I think that's acceptable.
There was a problem hiding this comment.
Ah, yes I was unaware of that integration. Maybe it should be a note on a Rack instead?
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
approved these changes
Aug 1, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #DNE
What's Changed
Adding in documentation regarding rack power utilization calculation