Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps CI are failing with jsonschema>=4.18 #4204

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Aug 3, 2023

Closes: NaN

Apps invoke unittest and CI are failing with jsonschema>=4.18. https://github.com/nautobot/nautobot-plugin-chatops/actions/runs/5746507834/job/15576085808#step:7:1119

invoke unittest passes with pip install jsonschema==4.17.3

What's Changed

  • Downgraded jsonschema<4.18

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead fix the apps?

@snaselj
Copy link
Contributor Author

snaselj commented Aug 3, 2023

Can we instead fix the apps?

We have to fix schema-enforcer. This is temporary solution.

upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3589167Z   File "/usr/local/lib/python3.8/site-packages/schema_enforcer/schemas/jsonschema.py", line 11, in <module>
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3589642Z     v7data = pkgutil.get_data("jsonschema", "schemas/draft7.json")
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3590436Z   File "/usr/local/lib/python3.8/pkgutil.py", line 638, in get_data
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3591047Z     return loader.get_data(resource_name)
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3592004Z   File "<frozen importlib._bootstrap_external>", line 1032, in get_data
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3592693Z FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/site-packages/jsonschema/schemas/draft7.js

@snaselj
Copy link
Contributor Author

snaselj commented Aug 3, 2023

Can we instead fix the apps?

We have to fix schema-enforcer. This is temporary solution.

upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3589167Z   File "/usr/local/lib/python3.8/site-packages/schema_enforcer/schemas/jsonschema.py", line 11, in <module>
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3589642Z     v7data = pkgutil.get_data("jsonschema", "schemas/draft7.json")
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3590436Z   File "/usr/local/lib/python3.8/pkgutil.py", line 638, in get_data
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3591047Z     return loader.get_data(resource_name)
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3592004Z   File "<frozen importlib._bootstrap_external>", line 1032, in get_data
upstream-test / unittest (develop)      Run Tests       2023-08-03T04:14:25.3592693Z FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.8/site-packages/jsonschema/schemas/draft7.js

https://github.com/networktocode/schema-enforcer/blob/4433f2dcbef7483de59a7b7abecf9bb8baf32503/schema_enforcer/schemas/jsonschema.py#L11

@snaselj
Copy link
Contributor Author

snaselj commented Aug 3, 2023

Created bugreport in schema-enforcer:
networktocode/schema-enforcer#156

changes/4205.fixed Outdated Show resolved Hide resolved
@bryanculver bryanculver mentioned this pull request Aug 3, 2023
7 tasks
@glennmatthews glennmatthews merged commit ba352b2 into develop Aug 3, 2023
17 checks passed
@glennmatthews glennmatthews deleted the u/snaselj-fix-apps-ci branch August 3, 2023 14:26
@bryanculver bryanculver added this to the v1.6.0 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants