Fix Node.js deprecated install script

[snaselj]

Closes: NaN

What's Changed

• Fixed Dockerfile Node.js setup_XX.x deprecated script.
• Split Dockerfile RUN into separate apt, npm and pip instructions for better readability.

Justification

There was 1 minute timeout during container build:

#12 14.37 ================================================================================
#12 14.37 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
#12 14.37 ================================================================================
#12 14.37 
#12 14.37                            SCRIPT DEPRECATION WARNING                    
#12 14.37 
#12 14.37   
#12 14.37   This script, located at https://deb.nodesource.com/setup_X, used to
#12 14.37   install Node.js is deprecated now and will eventually be made inactive.
#12 14.37 
#12 14.37   Please visit the NodeSource distributions Github and follow the
#12 14.37   instructions to migrate your repo.
#12 14.37   https://github.com/nodesource/distributions
#12 14.37 
#12 14.37   The NodeSource Node.js Linux distributions GitHub repository contains
#12 14.37   information about which versions of Node.js and which Linux distributions
#12 14.37   are supported and how to install it.
#12 14.37   https://github.com/nodesource/distributions
#12 14.37 
#12 14.37 
#12 14.37                           SCRIPT DEPRECATION WARNING
#12 14.37 
#12 14.37 ================================================================================
#12 14.37 ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
#12 14.37 ================================================================================
#12 14.37 
#12 14.37 TO AVOID THIS WAIT MIGRATE THE SCRIPT
#12 14.37 Continuing in 60 seconds (press Ctrl-C to abort) ...
#12 14.37 
#12 74.37 
#12 74.37 ## Installing the NodeSource Node.js 18.x repo...

[gsnider2195]

Please rebase to develop

[gsnider2195]

Is this line not required?

[gsnider2195]

Same question for the rest of the cleanup lines removed below

[gsnider2195]

We need the rm -rf /tmp/tmp*. It tries to clean up that directory as the nautobot user later in the python-dependencies stage and fails

[snaselj]

Is this line not required?

It's not necessary, as apt temporary folders are mounted as cache, lines 58, 59

[snaselj]

Same question for the rest of the cleanup lines removed below

The same, solved by mounting apt temporary folders to Docker cache.

[snaselj]

We need the rm -rf /tmp/tmp*. It tries to clean up that directory as the nautobot user later in the python-dependencies stage and fails

/mnt is mounted as a Docker cache at line 77, so the line 78: RUN pip install ... instruction do not leave any files in /tmp on the image.

[gsnider2195]

This build was failing for me when trying to delete a /tmp/tmp<random string> file yesterday but seems to be working now. Maybe I had a bad cache.

[snaselj]

Merged with the latest develop to include venv removal.