Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added netutilsparser to network_driver #4418

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Added netutilsparser to network_driver #4418

merged 5 commits into from
Sep 20, 2023

Conversation

itdependsnetworks
Copy link
Contributor

Closes: DNE

What's Changed

Add netutilsparser

image

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)

@itdependsnetworks itdependsnetworks force-pushed the add_netutilsparser branch 2 times, most recently from 804a9b1 to ac33e41 Compare September 10, 2023 02:59
@bryanculver bryanculver added the triage This issue is new and has not been reviewed. label Sep 11, 2023
@glennmatthews
Copy link
Contributor

Please target this PR to the develop branch rather than ltm/1.6. We should always be making code changes in develop first then making the decision as to whether it's justifiable to back-port them to the LTM branch after they've been accepted and merged.

@itdependsnetworks itdependsnetworks changed the base branch from ltm/1.6 to develop September 11, 2023 14:50
glennmatthews
glennmatthews reviewed Sep 13, 2023
View reviewed changes
nautobot/docs/release-notes/version-1.6.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
changes/4396.added Outdated Show resolved Hide resolved
nautobot/dcim/utils.py Show resolved Hide resolved
@glennmatthews glennmatthews removed the triage This issue is new and has not been reviewed. label Sep 15, 2023
@itdependsnetworks
Copy link
Contributor Author

itdependsnetworks commented Sep 17, 2023 •
edited
Loading

Safe to assume someone from core will have the poetry conflict? This is a moving target if someone from core doesn't handle and then merge instantly.

@bryanculver bryanculver merged commit 4935de2 into nautobot:develop Sep 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itdependsnetworks @glennmatthews @bryanculver