feature: implement object list view filters #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbert-mieczkowski-codilime
requested review from
bryanculver,
glennmatthews and
timizuoebideri1
|
@norbert-mieczkowski-codilime Wherever there is something that needs to be reviewed (your |
…ment-object-list-view-filters
bryanculver
reviewed
Sep 12, 2023
|
Right, the spacing you mentioned is something I'd like to discuss further before changing it here. |
Being addressed in #4458 |
bryanculver
changed the base branch from
develop
to
feature/new-ui-filtering
| content: <Text>You have successfully opened filters panel.</Text>, | ||
| content: ( | ||
| <FiltersPanelContent | ||
| // TODO(norbert-mieczkowski-codilime): use actual lookup fields rather than table headers |
There was a problem hiding this comment.
Do you need help from others on implementing the REST API to retrieve the lookup fields?
There was a problem hiding this comment.
Likely, I don't feel proficient in the Nautobot backend enough to do it myself
glennmatthews
approved these changes
Sep 15, 2023
|
We'll work on #4462 to take this the rest of the way. Merge this into a feature branch to move forward. |
bryanculver
deleted the
u/norbert-mieczkowski-codilime-3583-implement-object-list-view-filters
branch
4 tasks
bryanculver
added a commit
that referenced
this pull request
Sep 27, 2023
* feature: implement object list view filters (#4434) * feature: implement object list view filters * fix: typo * chore: add changelog * chore: update non filter query params in the new ui * Added `object_type` to metadata output when performing an `OPTIONS` query. * feature: use dynamic object type in filter lookup type queries * Addressing feedback --------- Co-authored-by: jathanism <jathan@gmail.com> Co-authored-by: Bryan Culver <bryan.culver@networktocode.com> * New UI - Add Live Search (#4463) * feature: implement object list view filters * fix: typo * chore: add changelog * chore: update non filter query params in the new ui * Added `object_type` to metadata output when performing an `OPTIONS` query. * feature: use dynamic object type in filter lookup type queries * Addressing feedback * Add prototype live search * Fix memoization, handle global search, detail view redirect. * Added changelog fragment * Address feedback --------- Co-authored-by: Norbert Mieczkowski <norbert.mieczkowski@codilime.com> Co-authored-by: jathanism <jathan@gmail.com> * Add filterset schema to rest api (#4521) * automatically populate filter type when only one option is available * Update nautobot/core/api/metadata.py Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> * Update nautobot/core/api/metadata.py Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> * Remove errorant changlog add. Remove style bug fixed upstream --------- Co-authored-by: Norbert Mieczkowski <117445994+norbert-mieczkowski-codilime@users.noreply.github.com> Co-authored-by: jathanism <jathan@gmail.com> Co-authored-by: Norbert Mieczkowski <norbert.mieczkowski@codilime.com> Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3583
What's Changed
Implement
ObjecListview filters inFiltersPanelContentcomponent. Additionally, fix some minor existing component lifecycle and style issues for the feature to work correctly.TODO
contentTypeinstead of the one temporarily hardcoded innautobot/ui/src/components/FiltersPanel.js:159lookup_field("Field" field), use allowed filter fields instead of table headers. See Add filterset field data to uiSchema in REST API for all models with filtersets #4462