Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev environment: eslint doesn't run against the local dev environment #4523

Closed
gsnider2195 opened this issue Sep 26, 2023 · 1 comment · Fixed by #4574
Closed

dev environment: eslint doesn't run against the local dev environment #4523

gsnider2195 opened this issue Sep 26, 2023 · 1 comment · Fixed by #4574
Assignees
@gsnider2195
Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected

Comments

@gsnider2195
Copy link
Contributor

gsnider2195 commented Sep 26, 2023 •
edited
Loading

Environment

  • Nautobot version (Docker tag too if applicable): 2.0.0-rc.3
  • Python version:
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

  1. invoke eslint

Expected Behavior

Runs against local dev code (ie nautobot/ui)

Observed Behavior

Runs against /opt/nautobot/ui in the nautobot container which is not mounted from local nautobot/ui
@gsnider2195 gsnider2195 added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. labels Sep 26, 2023
@gsnider2195 gsnider2195 changed the title dev environment: eslint and prettier don't run against the local dev environment dev environment: eslint doesn't run against the local dev environment Sep 26, 2023
@gsnider2195
Copy link
Contributor Author

Changing eslint to run on nodejs container fixed this for me

@bryanculver bryanculver removed the triage This issue is new and has not been reviewed. label Sep 27, 2023
@gsnider2195 gsnider2195 mentioned this issue Oct 2, 2023
Merged
7 tasks
@gsnider2195 gsnider2195 self-assigned this Oct 2, 2023
@gsnider2195 gsnider2195 added the emergent Unplanned work that is brought into a sprint after it's started. label Oct 2, 2023
@glennmatthews glennmatthews mentioned this issue Oct 4, 2023
Merged
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gsnider2195 gsnider2195

Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed invoke eslint not running against local development environment. nautobot/nautobot
2 participants
@bryanculver @gsnider2195