Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of using lowercase variables in Constance Config #4556

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

smk4664
Copy link
Contributor

@smk4664 smk4664 commented Sep 28, 2023

What's Changed

Document the use of lowercase variables in App provided Constance Config.

This is a stepping stone in addressing #4530, it does not try to define a standard, but shows how we can support existing conventions.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Did you manually test to confirm that the lowercase_example actually works? (I ask because all of the testing is naturally using @override_config, which I worry could have subtle differences from the actual Constance behavior.)

@smk4664
Copy link
Contributor Author

smk4664 commented Sep 28, 2023

Looks reasonable to me. Did you manually test to confirm that the lowercase_example actually works? (I ask because all of the testing is naturally using @override_config, which I worry could have subtle differences from the actual Constance behavior.)

Yep, I tested manually, and even tested in the plugin that I am implementing this in.

@bryanculver bryanculver merged commit ca8a8c7 into nautobot:develop Sep 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants