Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 1.6.x to 2.0.x leaves InterfaceRedundancyGroupAssociation fields defined incorrectly #4684

Closed
glennmatthews opened this issue Oct 20, 2023 · 0 comments · Fixed by #4732
Assignees
Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): 1.6.3 --> 2.0.2

Steps to Reproduce

  1. Install Nautobot 1.6.x.
  2. Create an InterfaceRedundancyGroup and associate Interfaces to it
  3. Upgrade to Nautobot 2.0.2

Expected Behavior

  • InterfaceRedundancyGroupAssociation.created should be a datetime rather than a date (this was acceptable in 1.6.x but is incorrect in 2.0.x where all created fields must be datetimes).
  • InterfaceRedundancyGroup.status should not be nullable (this was a known bug in 1.x but was fixed for all other models in 2.0.x)

Observed Behavior

In the upgrade case (unlike the initial-install-with-2.0 case), InterfaceRedundancyGroupAssociation.created is incorrectly still a date field, and InterfaceRedundancyGroup.status is incorrectly still nullable.

This is because migration nautobot/dcim/migrations/0022_interface_redundancy_group.py differs between 1.6.x and 2.0.x in these areas, but is already applied in the 1.6.x installation and not reapplied in the migration to 2.0.x.

Any migration fix here needs to test and validate at least the following scenarios:

  • Upgrade from 1.6.x to fixed version
  • Upgrade from 2.0.2 to fixed version
  • Initial install of fixed version
@glennmatthews glennmatthews added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. and removed triage This issue is new and has not been reviewed. labels Oct 20, 2023
@gsnider2195 gsnider2195 self-assigned this Oct 30, 2023
@gsnider2195 gsnider2195 added the emergent Unplanned work that is brought into a sprint after it's started. label Oct 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants