Fixes to support multiple Apps per package #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snaselj What else is there to be done to get it across the finish line? |
This PR is currently taken over by @whitej6, there will probably be more fixes comming here. Or would you rather finish this one and add other fixes to separate PRs? @HanlinMiao |
…r conditional logic to prepend if nto in plugin list
|
@HanlinMiao it is ready for review. |
snaselj
commented
Nov 29, 2023
glennmatthews
approved these changes
Nov 29, 2023
7 tasks
timizuoebideri1
pushed a commit
that referenced
this pull request
Dec 8, 2023
* fix: get_serializer_for_model to use model.__module__ * Changes to use app_config.name instead of app_label & removed need for conditional logic to prepend if nto in plugin list * extras and users needed to be prepended with nautobot. --------- Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> Co-authored-by: Jeremy White <jeremy.lee.w@me.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: NaN
What's Changed
app_config.nameinstead ofapp_label+ conditional logic.nautobot.core.api.utils.get_serializer_for_modelnautobot.core.utils.lookup.get_route_for_modelnautobot.core.utils.lookup.get_related_class_for_modelnautobot.extras.plugins.tables.InstalledPluginsTablenautobot.extras.plugins.views.InstalledPluginsViewTODO