Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting for file size limit on job generated files #4984

Closed
lampwins opened this issue Dec 14, 2023 · 2 comments · Fixed by #5007
Closed

Setting for file size limit on job generated files #4984

lampwins opened this issue Dec 14, 2023 · 2 comments · Fixed by #5007
Assignees
@glennmatthews
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone
v2.1

Comments

@lampwins
Copy link
Member

lampwins commented Dec 14, 2023 •
edited

As ...

Patti - Platform Admin

I want ...

A global configuration setting that allows me to specify a max file size for files generated by a job.

So that ...

Job authors and their uses cannot accidentally (or nefariously) overwhelm the storage backend with large files.

I know this is done when...

  • A new configuration setting for job_generated_file_max_size
  • Default of 10 MB (or some agreeable, sane default)
  • Available in constance

It would be ideal if the enforcement of the file size is not easily overridable by a knowledgeable job author, but if this proves to be a large effort, this is acceptable as a guardrail only.

Optional - Feature groups this request pertains to.

Database Changes

No response

External Dependencies

No response
@lampwins lampwins added type: feature Introduction of new or enhanced functionality to the application triage This issue is new and has not been reviewed. and removed triage This issue is new and has not been reviewed. labels Dec 14, 2023
@glennmatthews
Copy link
Contributor

As part of this work, we should enhance the FileProxy admin UI table to display the size of each stored file.

@lampwins lampwins added this to the v2.1 milestone Dec 18, 2023
@glennmatthews glennmatthews self-assigned this Dec 20, 2023
@glennmatthews glennmatthews mentioned this issue Dec 20, 2023
Merged
5 tasks
@glennmatthews glennmatthews linked a pull request Dec 20, 2023 that will close this issue
Add JOB_CREATE_FILE_MAX_SIZE setting #5007
Merged
5 tasks
@glennmatthews
Copy link
Contributor

implemented by #5007

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Status: Done
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Add JOB_CREATE_FILE_MAX_SIZE setting nautobot/nautobot
2 participants
@lampwins @glennmatthews