Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes early return conditional in ensure_git_repository the second time [LTM] #5042

Merged
merged 1 commit into from Jan 8, 2024
Merged

fixes early return conditional in ensure_git_repository the second time [LTM] #5042

merged 1 commit into from Jan 8, 2024

Conversation

Kircheneer
Copy link
Contributor

@Kircheneer Kircheneer commented Jan 3, 2024 •
edited

Closes: #4142

What's Changed

The type return by git.Repo.rev_parse("HEAD") was still off, i.e. not a string. This commit fixes this by converting it to a string.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@Kircheneer Kircheneer force-pushed the u/Kircheneer-ensure-git-repository-fix-2-ltm branch 3 times, most recently from 5548d32 to 536e731 Compare January 4, 2024 12:26
@Kircheneer
fixes early return conditional in ensure_git_repository - again.
0322584 
The type returned by `git.Repo.rev_parse("HEAD")` was still off, i.e. not
a string. This commit fixes this by converting it to a string.
@Kircheneer Kircheneer force-pushed the u/Kircheneer-ensure-git-repository-fix-2-ltm branch from 536e731 to 0322584 Compare January 4, 2024 12:29
@glennmatthews glennmatthews merged commit 76c269f into nautobot:ltm-1.6 Jan 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanlinMiao HanlinMiao HanlinMiao approved these changes

@gsnider2195 gsnider2195 gsnider2195 approved these changes

@timizuoebideri1 timizuoebideri1 timizuoebideri1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kircheneer @HanlinMiao @gsnider2195 @timizuoebideri1 @glennmatthews