Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactAssociation make Role required #5207

Closed
gsnider2195 opened this issue Feb 1, 2024 · 2 comments · Fixed by #5279
Closed

ContactAssociation make Role required #5207

gsnider2195 opened this issue Feb 1, 2024 · 2 comments · Fixed by #5279
Assignees
Labels
type: bug Something isn't working as expected
Milestone

Comments

@gsnider2195
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): 2.2.0a1
  • Python version:
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

  1. Create a contact association to an object without selecting a role
  2. Assign that same contact to the same object with the same status and no role

Expected Behavior

Failure because contact already exists on that object

Observed Behavior

Multiple associations are created because null != null on the role field

image

@gsnider2195 gsnider2195 added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. and removed triage This issue is new and has not been reviewed. labels Feb 1, 2024
@gsnider2195
Copy link
Contributor Author

As discussed, make role required

@lampwins lampwins added this to the v2.2 milestone Feb 1, 2024
@lampwins lampwins changed the title Uniqueness constraints for ContactAssociation don't account for null role ContactAssociation make Role required Feb 2, 2024
@HanlinMiao HanlinMiao self-assigned this Feb 12, 2024
@glennmatthews glennmatthews linked a pull request Feb 13, 2024 that will close this issue
7 tasks
@glennmatthews
Copy link
Contributor

Implemented in #5279.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants