Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Tab disappearing when the user navigates to Notes and Changelog Tabs #5214

Closed
HanlinMiao opened this issue Feb 1, 2024 · 2 comments · Fixed by #5279
Closed

Contact Tab disappearing when the user navigates to Notes and Changelog Tabs #5214

HanlinMiao opened this issue Feb 1, 2024 · 2 comments · Fixed by #5279
Assignees
@HanlinMiao
Labels
type: bug Something isn't working as expected
Milestone
v2.2

Comments

@HanlinMiao
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): v2.1
  • Python version:
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

  1. Go to any device's detail view.
  2. Navigate to the notes tab.
  3. Notice that the contacts tab disappeared on that page.

Screen Shot 2024-02-01 at 3 21 10 PM
Screen Shot 2024-02-01 at 3 21 18 PM

  1. Also notice this behavior is not present in model views with NautobotUIViewSet.
    Screen Shot 2024-02-01 at 3 20 44 PM
    Screen Shot 2024-02-01 at 3 21 33 PM

Expected Behavior

The contacts tab remains on the page and it is still navigatable.

Observed Behavior

The contacts tab disappeared.
@HanlinMiao HanlinMiao added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. labels Feb 1, 2024
@lampwins lampwins removed the triage This issue is new and has not been reviewed. label Feb 1, 2024
@lampwins lampwins mentioned this issue Feb 1, 2024
Closed
@HanlinMiao
Copy link
Contributor Author

We need to pass the context variable "is_contact_associatable_model": is_contact_associatable_model in ObjectNotesView and ObjectChangelogView. Whereas NautobotUIViewSet makes sure that this context variable is passed to all views by default.

nautobot/nautobot/core/views/renderers.py

Line 222 in 6742992

"is_contact_associatable_model": is_contact_associatable_model,

@lampwins lampwins added this to the v2.2 milestone Feb 1, 2024
@HanlinMiao HanlinMiao self-assigned this Feb 12, 2024
@HanlinMiao HanlinMiao mentioned this issue Feb 13, 2024
Merged
7 tasks
@glennmatthews glennmatthews linked a pull request Feb 13, 2024 that will close this issue
Address various Contact and Team model issues #5279
Merged
7 tasks
@glennmatthews
Copy link
Contributor

Fixed in #5279.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
v2.2
Development

Successfully merging a pull request may close this issue.

Address various Contact and Team model issues nautobot/nautobot
3 participants
@lampwins @glennmatthews @HanlinMiao