Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Address list view not correctly sorted by default #5283

Closed
glennmatthews opened this issue Feb 13, 2024 · 2 comments · Fixed by #5294
Closed

IP Address list view not correctly sorted by default #5283

glennmatthews opened this issue Feb 13, 2024 · 2 comments · Fixed by #5294
Assignees
@glennmatthews
Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): 2.1.4, appears broken as far back as 2.0.0

The /ipam/ip-addresses/ list view lists IPs in a seemingly random order:

image

Steps to Reproduce

  1. https://demo.nautobot.com/ipam/ip-addresses/

Expected Behavior

IPs to be ordered logically by default

Observed Behavior

Seemingly random ordering.

Looks to have been broken by #4230; I confirmed locally that reverting 536d75d appears to restore the expected ordering to the table.
@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Feb 13, 2024
@glennmatthews
Copy link
Contributor Author

Possibly should be using count_related instead of Count throughout nautobot.ipam.views.

@glennmatthews glennmatthews self-assigned this Feb 13, 2024
@glennmatthews
Copy link
Contributor Author

https://docs.djangoproject.com/en/3.2/topics/db/aggregation/#interaction-with-order-by

This was referenced Feb 14, 2024
Merged
Merged
@glennmatthews glennmatthews added the emergent Unplanned work that is brought into a sprint after it's started. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennmatthews glennmatthews

Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ordering of IP address tables nautobot/nautobot
1 participant
@glennmatthews