Error when navigating Tenant Groups via Tenant breadcrumbs

[matt852]

Environment

• Nautobot version (Docker tag too if applicable): 2.1.4
• Python version: n/a
• Database platform, version: n/a
• Middleware(s): n/a

Steps to Reproduce

1. Log into demo.nautobot.com
2. Go to a Tenant that is assigned to a Tenant Group (ie: ABC LLC)
3. In the breadcrumbs, click on the Tenant Group (ABC Holding Corp in this example)

Expected Behavior

I expect to be taken to the page for the selected Tenant Group.

Observed Behavior

Instead I am taken to a blank Tenants page, with an error banner displayed, saying:

Invalid filters were specified:
group
Unknown filter field

[glennmatthews]

Hyperlink needs to be updated to use tenant_group instead of group in 2.0.

[jifox]

Same problem when filtering vlans in vlan groups. Here the group must be updated to vlan_group

http://localhost:9317/ipam/vlans/?group=VG-ATGW

[glennmatthews]

@jifox can you specify where you're finding that incorrect link? Is it in a VLAN breadcrumb, or somewhere else?

[jifox]

@glennmatthews

I just open the VLANs and add a Filter for VLAN Group

[glennmatthews]

Thanks! Looks like that's a bug in VLANFilterForm. Looks like an issue in PrefixForm.vlan as well.

[glennmatthews]

We need to go through the code for anywhere in a filter, form, or link that has a group not prefixed with something and see if it needs fixing - at a glance, the below all look suspect:

nautobot/dcim/forms.py:        query_params={"group_id": "$cluster_group"},
nautobot/ipam/forms.py:            "group_id": "$vlan_group",
nautobot/ipam/forms.py:    group_id = DynamicModelMultipleChoiceField(
nautobot/ipam/templates/ipam/inc/vlangroup_header.html:        <a href="{% url 'ipam:vlan_add' %}?vid={{ first_available_vlan }}&group={{ object.pk }}{% if object.location %}&location={{ object.location.pk }}{% endif %}" class="btn btn-success">
nautobot/ipam/templates/ipam/vlan.html:        <li><a href="{% url 'ipam:vlan_list' %}?group={{ object.vlan_group.name }}">{{ object.vlan_group }}</a></li>
nautobot/tenancy/templates/tenancy/tenant.html:                    <li><a href="{% url 'tenancy:tenant_list' %}?group={{ object.tenant_group.name }}">{{ object.tenant_group }}</a></li>
nautobot/tenancy/templates/tenancy/tenantgroup.html:                    <a href="{% url 'tenancy:tenant_add' %}?group={{ object.pk }}" class="btn btn-xs btn-primary">
nautobot/virtualization/templates/virtualization/clustergroup.html:                        <a href="{% url 'virtualization:cluster_list' %}?group={{ object.name }}">{{ cluster_table.rows|length }}</a>
nautobot/virtualization/templates/virtualization/clustergroup.html:                    <a href="{% url 'virtualization:cluster_add' %}?group={{ object.pk }}" class="btn btn-xs btn-primary">