Changed the behaviour of Prefix table: allow sorting #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we doing this for all tree models (e.g. Tenant/Rack Groups) or only some? |
HanlinMiao
reviewed
Mar 19, 2024
HanlinMiao
reviewed
Mar 20, 2024
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
…hub.com/nautobot/nautobot into u/timizuoebideri-4811-prefix-ui-sorting
HanlinMiao
approved these changes
Mar 21, 2024
| @@ -42,28 +42,10 @@ | |||
| {% if record.present_in_database %}{% utilization_graph record.get_utilization %}{% else %}—{% endif %} | |||
| """ | |||
|
|
|||
| PREFIX_LINK = """ | |||
There was a problem hiding this comment.
Is this removed because it was unused? My only hesitation is whether we might have any apps that are relying on it that we don't know about.
There was a problem hiding this comment.
This was not exposed to the apps/plugin, or do plugin developers use constants not exposed to apps?
There was a problem hiding this comment.
They aren't supposed to but that doesn't mean they can't. Just being overly cautious here.
glennmatthews
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4811
What's Changed
Screenshots
5d39e694-6b1b-46a8-a789-507242cf6a08.mp4
TODO