Controllers remaining work

[glennmatthews]

• Add a blurb in the version-2.2.md Release Overview about this feature
• Refine JS in nautobot/dcim/templates/dcim/controllerdevicegroup_create.html:
  • Remove jQuery if possible
  • Replace console.log() in case of AJAX failure with something more user-friendly
• Refine controller_retrieve.html layout (Initial work on Controller Models #5325 (comment))
• Consolidate controller "developer" documentation with "user" documentation (Initial work on Controller Models #5325 (comment))
• Investigate whether changing the default columns shown in ControllerTable provides a better UX (Initial work on Controller Models #5325 (comment))
• Come to a conclusion about SET_NULL vs PROTECT on Controller.external_integration (Initial work on Controller Models #5325 (comment)) and Controller.deployed_controller/Controller.deployed_controller_group (Initial work on Controller Models #5325 (comment))

Update Controllers based on the discussion during the demo as follows:

• Remove Add button from the Controller Device Group main menu.
• Rename ControllerDeviceGroup => ControllerManagedDeviceGroup / Managed Device Group
• Rename Device.controller_device_group => controller_managed_device_group
• Rename Controller.deployed_* => controller_device / controller_device_redundancy_group.
• Controller Edit:
  • Split into sections, similar to retrieve.
  • Fields managed* exclusive similar to Provider Network vs Location tabs in Circuit Terminations.
• Controller Retrieve:
  • Rename Devices => Managed devices.
  • Remove duplicity role.
  • Merge Deployed* to the single field.
• Controller Device Group Edit:
  • Disabled fields are not included in the post, render field as hidden, use something like: {% render_field form.associated_object_id.as_hidden %}
  • Move Controller above Name.

[snaselj]

• Come to a conclusion about SET_NULL vs PROTECT on Controller.external_integration (Initial work on Controller Models #5325 (comment)) and Controller.deployed_controller/Controller.deployed_controller_group (Initial work on Controller Models #5325 (comment))

This is the last remaining question, what's your opinion pls.? @glennmatthews @whitej6 @mzbroch

[mzbroch]

This is the last remaining question, what's your opinion pls.? @glennmatthews @whitej6 @mzbroch

👍 for protect

[whitej6]

If field is null=True then on_delete=models.SET_NULL should be used. I originally used PROTECT but when Glenn pushed back I rethought

[snaselj]

Both fields can be null, so keeping SET_NULL, no change is necessary.

[glennmatthews]

If field is null=True then on_delete=models.SET_NULL should be used. I originally used PROTECT but when Glenn pushed back I rethought

I've changed my thinking since the initial pushback though :-) I think from a principle-of-least-astonishment standpoint it makes more sense to prevent users from deleting an ExternalIntegration that's actively in use by a Controller. Similarly for deleting a Device or DeviceRedundancyGroup that represent a Controller?

[whitej6]

Then I amend my amended vote to protect 😂

[snaselj]

As we are still on beta, I just updated the migration.