Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in filter tests in 2.2 #5502

Closed
gsnider2195 opened this issue Mar 29, 2024 · 0 comments · Fixed by #5505
Closed

Fix off-by-one error in filter tests in 2.2 #5502

gsnider2195 opened this issue Mar 29, 2024 · 0 comments · Fixed by #5505
Assignees
@gsnider2195
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@gsnider2195
Copy link
Contributor

Proposed Changes

This line needs to be reverted back to the 2.1 behavior (< instead of <=) and fix any tests failing as a result. Wait until 2.2 is merged into develop and released before making this change.

nautobot/nautobot/core/testing/filters.py

Line 47 in 1bf39ab

if value[field_name] and value["count"] <= qs_count:

@gsnider2195 gsnider2195 added the type: housekeeping Changes to the application which do not directly impact the end user label Mar 29, 2024
@gsnider2195 gsnider2195 self-assigned this Mar 29, 2024
@gsnider2195 gsnider2195 mentioned this issue Mar 29, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsnider2195 gsnider2195

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed off-by-one error in generic filter testing helper nautobot/nautobot
1 participant
@gsnider2195