fix: Fixes javascript error for LLDP neighbor view #5515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vanilla javascript rewrite of the LLDP neighbors view introduced a bug where an LLDP neighbor with a matching row (but no configured device) will raise an exception. This commit fixes that issue.
What's Changed
The recent LLDP view changes (in #5346) introduced a javascript bug. If the LLDP information returned includes a neighbor for a matching interface, but Nautobot has no configured device for that interface, then no DOM nodes match the query selectors for data attributes. Since no nodes match, no attributes can be looked up and an exception is thrown. This fix wraps all of the attribute lookups in a function that always returns a string (empty if not found).
Screenshots
No screenshots as the UI hasn't changed.
TODO
Attached Screenshots, Payload ExampleUnit, Integration TestsDocumentation Updates (when adding/changing features)Example App Updates (when adding/changing features)Outline Remaining Work, Constraints from Design