Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to graphene to latest #5745

Open
jamesharr opened this issue May 21, 2024 · 0 comments · May be fixed by #5746
Open

Upgrade to graphene to latest #5745

jamesharr opened this issue May 21, 2024 · 0 comments · May be fixed by #5746
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jamesharr
Copy link
Contributor

jamesharr commented May 21, 2024 •
edited

Proposed Changes

The graphene library is up to at least 3.3.x, but Nautobot is currently pinned to ~2.16.0 because 3.x includes some breaking changes.

Justification

References

  1. Update graphiql to latest #4769 - upgrade GraphIQL
  2. graphene-python issue 1365 - issue regarding N+1 queries
  3. Chat in #nautobot on NTC Slack about Graphene and N+1 query performance
  4. Graphene v3 release notes
@jamesharr jamesharr added triage This issue is new and has not been reviewed. type: housekeeping Changes to the application which do not directly impact the end user labels May 21, 2024
@jamesharr jamesharr linked a pull request May 21, 2024 that will close this issue
Draft
7 tasks
@gsnider2195 gsnider2195 removed the triage This issue is new and has not been reviewed. label May 23, 2024
@jamesharr jamesharr mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DRAFT: Upgrade Graphene to 3.2.x jamesharr/nautobot
2 participants
@jamesharr @gsnider2195