Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker build to use new Poetry installer #918

Closed
glennmatthews opened this issue Sep 15, 2021 · 1 comment
Closed

Update docker build to use new Poetry installer #918

glennmatthews opened this issue Sep 15, 2021 · 1 comment
Assignees
Labels
good first issue Great issues for newcomers! type: housekeeping Changes to the application which do not directly impact the end user
Milestone

Comments

@glennmatthews
Copy link
Contributor

Proposed Changes

As seen in Docker build:

#8 [dev  3/14] RUN curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py -o /tmp/get-poetry.py &&     python /tmp/get-poetry.py &&     rm -f /tmp/get-poetry.py
#8 sha256:9ca25b50606107a3c6c57449104b10922ee10343f446931c55cd3bf241593322
#8 0.713 Retrieving Poetry metadata
#8 0.853 
#8 0.857 This installer is deprecated. Poetry versions installed using this script will not be able to use 'self update' command to upgrade to 1.2.0a1 or later.

Justification

We should migrate from get-poetry.py to install-poetry.py in order to make use of newer versions of Poetry as they become available.

@glennmatthews glennmatthews added workflow: under review type: housekeeping Changes to the application which do not directly impact the end user labels Sep 15, 2021
@jedelman8 jedelman8 added this to the v1.3.0 milestone Oct 22, 2021
@glennmatthews glennmatthews mentioned this issue Nov 16, 2021
@glennmatthews glennmatthews added the good first issue Great issues for newcomers! label Dec 13, 2021
@glennmatthews
Copy link
Contributor Author

Fixed in #1073.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Great issues for newcomers! type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants