Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Group detail membership tab pagination is broken #2219

Closed
jathanism opened this issue Aug 16, 2022 · 3 comments · Fixed by #2240
Closed

Dynamic Group detail membership tab pagination is broken #2219

jathanism opened this issue Aug 16, 2022 · 3 comments · Fixed by #2240
Assignees
Labels
type: bug Something isn't working as expected
Milestone

Comments

@jathanism
Copy link
Contributor

Environment

  • Python version: *
  • Nautobot version: 1.4.0

Steps to Reproduce

  1. Navigate to a Dynamic Group detail view in the web UI that has more than 25 members
  2. Click next page

Expected Behavior

View should stay on the "members" tab.

Observed Behavior

It returns you to the "main" tab. It also does not persist the page size setting.

@jathanism jathanism added the type: bug Something isn't working as expected label Aug 16, 2022
@jathanism jathanism added this to the v1.4.1 milestone Aug 16, 2022
@jathanism jathanism self-assigned this Aug 16, 2022
@jathanism
Copy link
Contributor Author

The issue is that when you click to paginate the Members tab, the tab=members URL fragment doesn't persist (and neither does the one for page_size=). Seems safe to assume fixing one may fix both.

@jathanism
Copy link
Contributor Author

After thinking I had arrived at a fix, I determined that I had not. But I can assert correct behavior like so:

  1. Navigate to a Dynamic Group detail view in the web UI that has more than 25 members
  2. Refresh the page
  3. Observe the URL fragments are correct
  4. For that session it works as intended until you navigate away from the Members tab

There's a state persistence issue here. Perhaps in our JS history handling code as it relates to nav tabs.

@jathanism
Copy link
Contributor Author

jathanism commented Aug 17, 2022

Root cause is that the nav tab switching is done client-side, while the pagination is done server-side.

jathanism added a commit that referenced this issue Aug 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant