Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undercurl support for this theme ? #183

Open
ipatch opened this issue Aug 12, 2023 · 3 comments
Open

undercurl support for this theme ? #183

ipatch opened this issue Aug 12, 2023 · 3 comments

Comments

@ipatch
Copy link

ipatch commented Aug 12, 2023

first off, hello and thank you for this theme. 🙏 recently i've noticed several newer terminals such as kitty and alacritty (my daily driver) have added support for undercurls (under curls), and so has tmux. i've verified with alacritty,

echo -e "\e[4:3mTEST"

added the below to my tmux.conf

# tmux / styling / undercurl, under curl
set -as terminal-overrides ',*:Smulx=\E[4::%p1%dm'  # undercurl support
set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'  # underscore colours - needs tmux-3.0

and reran the above echo command within tmux and got undercurls displaying.

image

however, i'm currently not seeing any undercurls for misspellings in a document using neovim when i toggle spell checking. i'm still just seeing a straight red line.

image

would this be a feature this colorscheme could enable eventually or are we the user of this colorscheme expected to enable this setting ourselves? thanks again for this colorscheme. 🙏

@ipatch
Copy link
Author

ipatch commented Aug 12, 2023

forgive me for not rereading the readme 🤦‍♂️ i do see, there is support for undercurls and sure enough i see them below on lsp diagnositic messages. But I do not seem them when i toggle spell checking, i assume that is something i need to setup on my end?

image

@ipatch
Copy link
Author

ipatch commented Aug 13, 2023

okay so opening of a markdown document ie. a README.md, toggling spell checking and running :Inspect on a misspelling gives me the below output,

Treesitter
  - @spell.markdown links to @spell markdown


Press ENTER or type command to continue

image

i think there should be a treesitter update for @spell possibly for the below file?

["@string"] = {fg = c.green, fmt = cfg.code_style.strings},

@ipatch
Copy link
Author

ipatch commented Aug 13, 2023

this got me the results i was looking for,

-- NOTE: ipatch below line required or bg color is not updated in terminal
cmd [[silent! colorscheme onedark]]

-- ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ NOTE: ipatch, this needs to be below the `colorscheme onedark` cmd above
vim.cmd [[hi SpellBad gui=undercurl]]

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant