Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX #420

Open
Chenyang0324 opened this issue Jan 18, 2019 · 4 comments
Open

AndroidX #420

Chenyang0324 opened this issue Jan 18, 2019 · 4 comments

Comments

@Chenyang0324
Copy link

For anyone is facing AndroidX migration issue.
try this.
implementation 'com.github.Chenyang0324:MaterialDesignLibrary:1.10'

@taar1
Copy link

taar1 commented Jan 21, 2019

I just tried it out but I still get this error:

ERROR: Unable to resolve dependency for ':app@googlePlayFlavorDebug/compileClasspath': Could not resolve com.android.support:support-v4:22.+.

@Chenyang0324
Copy link
Author

@taar1
Check if there is any other place is referencing support library.
The app should be no longer referencing any support library if you are migrating to Android X.

@taar1
Copy link

taar1 commented Jan 22, 2019

I just did another test. I commented this out:
implementation 'com.github.Chenyang0324:MaterialDesignLibrary:1.10'

and I could build the app without error messages (well except the errors I get for not having the MaterialDesignLibrary in the project but references to it in the code).
As soon as I uncomment it and try to build it I get this error:

ERROR: Unable to resolve dependency for ':app@googlePlayFlavorDebug/compileClasspath': Could not resolve com.android.support:support-v4:22.+.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@googlePlayFlavorDebugAndroidTest/compileClasspath': Could not resolve com.android.support:support-v4:22.+.
Show Details
Affected Modules: app

ERROR: Unable to resolve dependency for ':app@googlePlayFlavorDebugUnitTest/compileClasspath': Could not resolve com.android.support:support-v4:22.+.
Show Details
Affected Modules: app

@taar1
Copy link

taar1 commented Jan 22, 2019

I just looked at your fork and saw you still have a support-v4 dependency in there.

https://github.com/Chenyang0324/MaterialDesignLibrary/blob/master/MaterialDesignLibrary/MaterialDesign/build.gradle

dependencies {
compile 'com.nineoldandroids:library:2.4.+'
compile 'com.android.support:support-v4:22.+'
compile fileTree(dir: 'libs', include: '*.jar')
}

Could you remove that dependency and make a new version? I think after that it should build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants