Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use satoshi_round() in rpc-tests #362

Open
djksa opened this issue Dec 13, 2018 · 1 comment
Open

Use satoshi_round() in rpc-tests #362

djksa opened this issue Dec 13, 2018 · 1 comment

Comments

@djksa
Copy link
Contributor

djksa commented Dec 13, 2018 •
edited
Loading

It would be better to use the satoshi_round() function, defined in qa/rpc-tests/test_framework/util.py for rounding decimals which are not 8 decimals places long, than converting the decimal to string and so forth and adding "00" / splicing decimal places off.

See line 119 in qa/rpc-tests/coldstaking_spending.py for an example of what could be replaced by satoshi_round().
@matt-auckland matt-auckland added this to the 4.5.1 milestone Dec 13, 2018
@djksa
Copy link
Contributor Author

djksa commented Dec 13, 2018 •
edited
Loading

Working on this right now. Commits will be pushed to my branch before merging to master here. Currently fixing qa/rpc-tests/coldstaking_spending.py

Update: @matt-auckland I think the issue is now fixed on my branch ✔️

@matt-auckland matt-auckland removed this from the 4.5.2 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matt-auckland @djksa and others