-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] What about parsing requirements.txt? #11
Comments
This is a pretty crucial feature. As we all know, pip is not perfect at dependency resolution. Therefore, for serious workflows one needs to be able to parse and resolve the requirements with external tools like pip-tools, especially pip-compile. For this workflow, having a requirements file which is only parsed by setup.py is extremely usefull... |
This is not considered good practice. I've done it in a few projects, but got yelled at for it. |
@kennethreitz so it is better practice to maintain a duplicated requirements list? one on setup.py and other on requirements.txt to enable the tools mentioned above? |
You are certainly free to merge them for your own needs, but this repo won't do that. |
like i said, I've done it before :) |
@rochacbruno take a look at |
I know this is closed but just so everyone knows: the current best practice it to put https://github.com/ofek/hatch does this for new projects by default |
Agreed, if that is your desired behavior. |
@ofek I think it is only good for application projects, which are meant to be installed in |
agreed with @webknjaz |
https://github.com/kennethreitz/setup.py/blob/c5a82dc3670b5fa65e4d5da578d992c38b62d524/setup.py#L22
2 years ago I was playing with this http://j.mp/setup_py and one of the features is using
pip.req.parse_requirements('requirements.txt')
to populate the requires and avoid duplicity.What do you think about this? on advantage of having a
requirements.txt
is to use pyup.io andsatefy
to check updates and audit the requirements for security failures.The text was updated successfully, but these errors were encountered: