Use MutateObserver to prevent loading lag #22
Conversation
| } |
There was a problem hiding this comment.
Remove the extra space. This file should not be shown as changed file
| for (let i = 0; i < timesToJSrun.length; i++) { | ||
| setTimeout(() => { clasifyImages() }, timesToJSrun[i]); | ||
| } | ||
| //Call function when changes made in DOM tree |
There was a problem hiding this comment.
When you load a web page at first the images are hidden without any lag. But when the same page is reloaded, the filter does not work. Also I am experiencing considerable slowing down of my browser while running the extension that did not happen before
There was a problem hiding this comment.
Which page are you testing with? And when you say reload, does that mean refreshing?(I tried https://scrolller.com/nsfw and it seems to work). Is there a way to see the slowing down of the browser? I didn't notice it.
There was a problem hiding this comment.
I tested with Google Images. I tried to reload/refresh on the browser and the filter did not seem to work then. I tried with the current MASTER branch and the PR and there was a considerable lag between them. Could you test it out thoroughly?
|
@yxlin118 Please test it once again and check if you are experiencing any issues |
|
@yxlin118 Thanks for contributing, pls check my PR #26, now we can handle dynamic JS rendering, you'll go to website in README and choose only But your bug #19 is still exists, I mean Im not sure thats about dynamic render or not, it takes <250ms to hide every image, but I still have no idea how to remove this time lag, hope we will find solution |
|
v1.0.0 is merged #29, thanks for your contribution |
issue #19