fix: throw errors instead of alerts

naver · Mar 23, 2014 · 12cf47d · 12cf47d
1 parent 08d1894
commit 12cf47d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/c3.js b/c3.js
@@ -991,8 +991,7 @@
 
             // check "x" is defined if timeseries
             if (isTimeSeries && xs.length === 0) {
-                window.alert('data.x or data.xs must be specified when axis.x.type == "timeseries"');
-                return [];
+                throw new Error('data.x or data.xs must be specified when axis.x.type == "timeseries"');
             }
 
             // save x for update data by load
@@ -1880,8 +1879,7 @@
 
             selectChart = d3.select(__bindto);
             if (selectChart.empty()) {
-                window.alert('No bind element found. Check the selector specified by "bindto" and existance of that element. Default "bindto" is "#chart".');
-                return;
+                throw new Error('No bind element found. Check the selector specified by "bindto" and existance of that element. Default "bindto" is "#chart".');
             } else {
                 selectChart.html("");
             }