fix(api): Cancel transitions on destroy.

- Interrupt possible transition pending on .destroy()
- Add condition to check unexpected async .load() call after is already
destroyed

Fix #766
Close #765

AUTHORS.txt

@@ -24,3 +24,4 @@ Rex <rexebin@gmail.com>
 Alexandre Araujo <https://github.com/oliveiraaraujo>
 Jinwoo Oh <arkist@gmail.com>
 Nirmal Guna <gunaseelann@jfrog.com>
+Michael Yungerman <myungerman@lightricks.com>

spec/api/api.chart-spec.js

@@ -133,6 +133,24 @@ describe("API chart", () => {
 			expect(Object.keys(chart).length).to.be.equal(0);
 			expect(bb.instance.indexOf(chart) === -1).to.be.true;
 		});
+
+		it("should be destroyed without throwing error", done => {
+			chart = util.generate({
+				data: {
+					columns: [["data1", 50, 20]]
+				}
+			});
+
+			setTimeout(() => {
+				chart.load({
+					columns: [["data1", 100, 150]],
+					unload: ["data1"]
+				});
+
+				chart.destroy();
+				setTimeout(done, 500);
+			}, 500);
+		});
 	});
 
 	describe("config()", () => {

src/api/api.chart.js

@@ -73,7 +73,8 @@ extend(Chart.prototype, {
 		if (notEmpty($$)) {
 			$$.charts.splice($$.charts.indexOf(this), 1);
 
-			// clear timers
+			// clear timers && pending transition
+			$$.svg.select("*").interrupt();
 			isDefined($$.resizeTimeout) && window.clearTimeout($$.resizeTimeout);
 
 			window.removeEventListener("resize", $$.resizeFunction);

src/data/data.load.js

@@ -57,6 +57,11 @@ extend(ChartInternal.prototype, {
 		const $$ = this;
 		let data;
 
+		// prevent load when chart is already destroyed
+		if (!$$.config) {
+			return;
+		}
+
 		// reset internally cached data
 		$$.resetCache();