-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billboard.js 1.11.0 doesn't support IE 11 #1145
Comments
Hi @imbyungjun, I ran the build and seems working fine. Could you provide detailed reproducible case? |
@imbyungjun, from the From this change, when you import billboard.js, the dependent d3 modules will be concatenated & bundled in your build from the If you use This issue will not have effect if you include as So, there're two possible solutions on this. 1) Make 'd3-*' modules to be transpiledWhen your bundler(ex. webpack) configuration set is excluding // webpack.config.js
module: {
rules: [
{
test: /(\.js)$/,
exclude: {
test: /node_modules/,
not: [/(d3\-.*)$/]
},
use: {
loader: "babel-loader"
},
}, ProsYou can apply your own optimized configuration for dependent modules. ConsYou might need to handle all of possible legacy related polyfills and transformation needed. 2) Use transpiled d3 packaged buildIf you don't want to handle all possible configuration for legacy browsers, just use packaged build. import {bb} from "billboard.js/dist/billboard.pkgd";
bb.generate(...); In this case, you need to add on your bundler configuration to not concatenate // webpack.config.
externals: /^(d3\-.*)$/i, ProsGet rid all the headache configuration for the legacy environment. ConsMight possibly make bigger the build size, because of polyfills. |
Appreciate for your detailed guide! It perfectly works for me. I fixed it by transpiling d3-* modules.
|
If you are using babel7 and |
FYI @jm-chong, @imbyungjun |
Description
Billboard.js v1.11.0 doesn't work in IE.
I think that it's because It depends on d3-array 2.4.0 that doesn't support IE anymore. d3/d3-array#87
billboard.js/package.json
Line 110 in fbb8946
The text was updated successfully, but these errors were encountered: