fix(legend): legend.inset.anchor is working again #1936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored 'getCurrentPaddingRight(withoutTickTextOverflow = false)' to 'getCurrentPaddingRight(withXAxisTickTextOverflow = false)'. From now on, if 'getCurrentPaddingRight()' is called without passing parameters 'xAxisTickOverflow' will be 0 and 'getXAxisTickTextY2Overflow()' will only be called when autorotate x axis ticks is enabled.
|
@michkami thanks for the fix! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
# [3.0.0-next.2](3.0.0-next.1...3.0.0-next.2) (2021-03-05) ### Bug Fixes * **api:** fix loading area-line-range ([fe46492](fe46492)), closes [#1938](#1938) * **legend:** fix hiding via .hide() ([c489a77](c489a77)), closes [#1950](#1950) * **legend:** legend.inset.anchor is working again ([b5ba930](b5ba930)), closes [#1935](#1935) [#1936](#1936) * **zoom:** fix x Axis tick transition during zoom ([3f08b11](3f08b11)), closes [#1949](#1949) ### Features * **candlestick:** Intent to ship candlestick ([8d37bd8](8d37bd8)), closes [#76](#76) [#1167](#1167) * **candlestick:** Intent to ship candlestick type ([42307cb](42307cb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1935
Details
Refactored
getCurrentPaddingRight(withoutTickTextOverflow = false)togetCurrentPaddingRight(withXAxisTickTextOverflow = false).From now on, if
getCurrentPaddingRight()is called without passing parametersxAxisTickOverflowwill be 0 andgetXAxisTickTextY2Overflow()will only be called when x axis ticks autorotate is enabled.