Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): calculate x axis height correctly for negative tick rotation settings #1995

Conversation

GDFaber
Copy link
Collaborator

@GDFaber GDFaber commented Mar 19, 2021

Issue

#1994

Details

  • use absolute rotate value for calculation inside getHorizontalAxisHeight()
  • added unit test for negative rotate value

…on settings

use absolute rotate value for calculation inside getHorizontalAxisHeight()

Ref naver#1994
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.076% when pulling 1ff8873 on GDFaber:calculate_x_axis_height_with_negative_ticks_rotation into de06361 on naver:master.

@netil netil closed this in fe42e64 Mar 23, 2021
@netil netil added the bug label Mar 23, 2021
@netil netil added this to the 3.0 milestone Mar 23, 2021
@netil
Copy link
Member

netil commented Mar 23, 2021

@GDFaber thanks for the contribution!

github-actions bot pushed a commit that referenced this pull request Mar 26, 2021
## [3.0.1](3.0.0...3.0.1) (2021-03-26)

### Bug Fixes

* **axis:** calculate x axis height correctly for negative tick rotation settings ([fe42e64](fe42e64)), closes [#1994](#1994) [#1995](#1995)
* **candlestick:** fix exporting candlestick module ([1a9b75b](1a9b75b)), closes [#2007](#2007)
* **deploy:** fix deploying gh-pages ([baec455](baec455))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants