Fix to referenced but missing d3 types #2961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josundt, thanks for the contribution! |
|
@netil My pleasure 👍 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
# [3.7.0-next.1](3.6.3...3.7.0-next.1) (2022-12-07) ### Bug Fixes * **axis:** Fix axis label overlap when has no data ([643357b](643357b)), closes [#2974](#2974) * **axis:** fix axis.y/y2.tick.format context error ([54ee419](54ee419)), closes [#2976](#2976) * **domain:** Fix wrong domain range setting ([b55b153](b55b153)), closes [#2962](#2962) * **options:** Fix data.regions path rendering for category axis ([249d0ac](249d0ac)), closes [#2950](#2950) * **types:** Add missing param definition for gauge.label.format ([d663532](d663532)), closes [#2946](#2946) * **types:** Fix to referenced but missing d3 types ([0b57454](0b57454)), closes [#2954](#2954) [#2961](#2961) * **types:** Support dual module type.d in TS >= 4.7 ([143e491](143e491)), closes [#2952](#2952) [#2953](#2953) ### Features * **api:** Enhance .export() to preserve fontStyle ([0809ae7](0809ae7)), closes [#2892](#2892) * **arc:** Intent to ship arc.cornerRadius ([e8320cf](e8320cf)), closes [#2936](#2936) * **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202) * **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873) * **tooltip:** Enhance passing ratio value for stacked area/bar ([9e7ff01](9e7ff01)), closes [#2921](#2921)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
# [3.7.0](3.6.3...3.7.0) (2023-01-11) ### Bug Fixes * **axis:** Fix axis label overlap when has no data ([643357b](643357b)), closes [#2974](#2974) * **axis:** fix axis.y/y2.tick.format context error ([54ee419](54ee419)), closes [#2976](#2976) * **domain:** Fix wrong domain range setting ([b55b153](b55b153)), closes [#2962](#2962) * **options:** Fix data.regions path rendering for category axis ([249d0ac](249d0ac)), closes [#2950](#2950) * **plugin:** Fix stanford scale to accept 0 as min value ([02c4270](02c4270)), closes [#2999](#2999) * **selection:** Fix selection w/point.focus.only=true & selection.multiple=false ([af93a8a](af93a8a)), closes [#2928](#2928) [#3013](#3013) * **types:** Add missing param definition for gauge.label.format ([d663532](d663532)), closes [#2946](#2946) * **types:** Fix to referenced but missing d3 types ([0b57454](0b57454)), closes [#2954](#2954) [#2961](#2961) * **types:** Support dual module type.d in TS >= 4.7 ([143e491](143e491)), closes [#2952](#2952) [#2953](#2953) ### Features * **api:** Enhance .export() to preserve fontStyle ([0809ae7](0809ae7)), closes [#2892](#2892) * **arc:** Intent to ship arc.cornerRadius ([e8320cf](e8320cf)), closes [#2936](#2936) * **tooltip:** Enhance passing ratio value for stacked area/bar ([9e7ff01](9e7ff01)), closes [#2921](#2921) * **treemap:** Intent to ship treemap type ([9809ef1](9809ef1)), closes [#123](#123) [#3002](#3002) [#3004](#3004) [#3006](#3006) [#3007](#3007) [#3008](#3008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2954
Details
This fixes issue #2954 - so that compilation will work again in TypeScript projects with the billboard package installed.
I have added the 2 required types packages (with version "*") to package.json
dependencies.The two dependencies/versions are identical to the way they appear in the
dependenciessection of package.json inside the@types/d3package.NB! The yarn.lock file should probably also have been updated, but I unfortunately have little experience with yarn.
I hope you someone else can take care of that after merging the PR.