Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping of Components #766

Closed
wants to merge 2 commits into from
Closed

Overlapping of Components #766

wants to merge 2 commits into from

Conversation

chayou20
Copy link

@chayou20 chayou20 commented Dec 7, 2022

Issue

Details

Description

1
4

I find overlapping components of Showcases Page.

image

image

and checked z-index of .navbar--fixed-top and artwindow-overlay

'--ifm-z-index-fixed' value is 9 and 'z-index of artwindow-overlay' is 12 on this page

I checked this source code in local but It has different value

'--ifm-z-index-fixed' is 200 and 'z-index of artwindow-overlay' is 2001.

image

I tried to modify the file in the path above, but it didn't work.

I think that changed on a page that actually works.

So I added the code below to the custom.css file and modified it.

image

before

bandicam-2022-12-08-01-52-40-286

after

bandicam-2022-12-08-01-52-56-284

Steps to check or reproduce

…100%로 변경

다음 panel의 일부분이 보이는 것을 수정함.
previous z-index of .navbar--fixed-top is --ifm-z-index-fixed
it's 200 in local and causes overlapping of components in showcases.
z-index of some components is 2001 and greater than z-index of navbar
Copy link
Contributor

@malangfox malangfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -60,7 +60,7 @@
z-index: 2;
border-left: 0;
border-right: 0;
width: 88%;
width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bug.
This is intentional in Naver's actual CSS, showing it has the next panel to swipe.

@malangfox
Copy link
Contributor

This PR has been closed with no updates.
Issue #765 has been resolved by releasing version 4.10.6 of the document.

@malangfox malangfox closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants