Add JoinableExpressionGenerator interface #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
acktsap,
benelog,
jwChung,
mhyeon-lee and
SooKim1110
mhyeon-lee
approved these changes
Jan 5, 2023
acktsap
approved these changes
Jan 5, 2023
| infix fun intoGetter(getter: KFunction1<T, Boolean>): Exp<Boolean> = | ||
| Exp(delegate.join(PropertyExpressionGenerator(KotlinGetterProperty(getter)))) | ||
| interface JoinableExpressionGenerator<F, T> : ExpressionGenerator { | ||
| infix fun <R> into(property: KProperty1<T, R?>): JoinableExpressionGenerator<F, R> |
There was a problem hiding this comment.
이 pr하고 별개의 이야기긴 한데 이런 부분에서 <R>을 <R : Any>로 바꾸는건 어떠신가요? <R>이 사실 <R : Any?>인데 인자로 들어오는 property: KProperty<T, R?>에도 물음표가 붙어있어서 중복인 느낌이긴 해서요.
mhyeon-lee
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add JoinableExpressionGenerator for Exp
(Optional): Description
Removing class
Exp,ExpListSplitting ExpressionGenerators into
ExpressionGeneratorExtensionsandExpressionGeneratorsfor better readability