Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions for scripts and dos formatting #22

Closed
mingu6 opened this issue May 24, 2021 · 3 comments
Closed

Permissions for scripts and dos formatting #22

mingu6 opened this issue May 24, 2021 · 3 comments

Comments

@mingu6
Copy link

mingu6 commented May 24, 2021

Hi,

Thanks for all of your great work on this! I have a minor bug to report around the scripts in the tools/ folder. I am running Ubuntu 20.04 and have installed Kapture through pip using an empty conda environment with python=3.7.

Two issues:

  1. all scripts in the tools/ folder, e.g. kapture_download_dataset.py are not executable upon installation. I can manually fix this of course, but not ideal every time Kapture is installed/updated.
    kapture_download_dataset.py update
    zsh: permission denied: kapture_download_dataset.py
  2. After making the script executable within the package directory, executing the script again yields the following error:
    kapture_download_dataset.py update
    /usr/bin/env: ‘python3\r’: No such file or directory
    This is due to special characters or something through Windows or something. I can again easily fix this by running dos2unix on all tools but again this is suboptimal every time kapture is installed/updated.

Is there any way to address this for future releases? I remember a few releases ago this was not an issue.

@yocabon
Copy link
Contributor

yocabon commented May 25, 2021

Hi, this might be because I pushed the release to pip this time and I work on windows.
There shouldn't be a problem with the files from the repository (I check they are 755, except a few that I fixed, and I don't get the error when I try to run them on our linux server) so we'll take a look and probably re-upload the release.

@nguerin
Copy link
Contributor

nguerin commented May 25, 2021

Hi,
We fixed the package so that the scripts are now directly executable when installed with pip.
You can directly use the newer version (1.1.1).
Thanks for your feedback!

@nguerin nguerin closed this as completed May 25, 2021
@mingu6
Copy link
Author

mingu6 commented May 26, 2021

Works a treat, thanks! Keep up the great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants