refactoring

pinpoint-apm · Jun 5, 2015 · 0c3b528 · 0c3b528
1 parent 5935b74
commit 0c3b528
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/plugins/user/.gitignore b/plugins/user/.gitignore
@@ -0,0 +1,5 @@
+/target/
+/.settings/
+/.classpath
+/.project
+/*.iml
diff --git a/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserConstants.java b/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserConstants.java
@@ -21,6 +21,4 @@
  *
  */
 public interface UserConstants {
-    public static final String HTTP_CLIENT3_SCOPE = "HttpClient3Scope"; 
-    public static final String HTTP_CLIENT3_CONNECTION_SCOPE = "HttpClient3HttpConnection";
 }
diff --git a/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserPlugin.java b/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserPlugin.java
@@ -21,7 +21,6 @@
 import com.navercorp.pinpoint.bootstrap.logging.PLoggerFactory;
 import com.navercorp.pinpoint.bootstrap.plugin.ProfilerPlugin;
 import com.navercorp.pinpoint.bootstrap.plugin.ProfilerPluginContext;
-import com.navercorp.pinpoint.bootstrap.plugin.transformer.BaseClassFileTransformerBuilder;
 import com.navercorp.pinpoint.bootstrap.plugin.transformer.ClassFileTransformerBuilder;
 import com.navercorp.pinpoint.bootstrap.plugin.transformer.MethodTransformerBuilder;
 import com.navercorp.pinpoint.bootstrap.plugin.transformer.MethodTransformerProperty;
@@ -36,9 +35,11 @@ public class UserPlugin implements ProfilerPlugin, UserConstants {
     @Override
     public void setup(ProfilerPluginContext context) {
         final UserPluginConfig config = new UserPluginConfig(context.getConfig());
+
+        // add user include methods 
         for (String fullQualifiedMethodName : config.getIncludeList()) {
             try {
-                addUserDefineClass(context, fullQualifiedMethodName);
+                addUserIncludeClass(context, fullQualifiedMethodName);
                 if(logger.isDebugEnabled()) {
                     logger.debug("Add user include class interceptor {}", fullQualifiedMethodName);
                 }
@@ -48,7 +49,7 @@ public void setup(ProfilerPluginContext context) {
         }
     }
 
-    private void addUserDefineClass(ProfilerPluginContext context, final String fullQualifiedMethodName) {
+    private void addUserIncludeClass(ProfilerPluginContext context, final String fullQualifiedMethodName) {
         final String className = toClassName(fullQualifiedMethodName);
         final String methodName = toMethodName(fullQualifiedMethodName);
         final ClassFileTransformerBuilder classEditorBuilder = context.getClassFileTransformerBuilder(className);

diff --git a/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserPluginConfig.java b/plugins/user/src/main/java/com/navercorp/pinpoint/plugin/user/UserPluginConfig.java
@@ -19,7 +19,6 @@
 import java.util.Collections;
 import java.util.List;
 
-import com.navercorp.pinpoint.bootstrap.config.DumpType;
 import com.navercorp.pinpoint.bootstrap.config.ProfilerConfig;
 
 /**