Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextStyle > BoxShadow 콤마 중복 수정 #3

Merged
merged 2 commits into from Feb 22, 2020
Merged

TextStyle > BoxShadow 콤마 중복 수정 #3

merged 2 commits into from Feb 22, 2020

Conversation

Kiboom
Copy link

@Kiboom Kiboom commented Feb 21, 2020

이슈

TextStyle 내 BoxShadow 뒤에 콤마가 두 개 들어가는 현상을 수정하였습니다.

스크린샷 2020-02-21 오후 6 43 21

해결

  1. TextStyle 내에 BoxShadow의 위치를 맨 뒤로 이동하였습니다.
  2. TextStyle 의 다른 프로퍼티와는 달리 BoxShadow 뒤에는 콤마를 붙이지 않도록 수정하였습니다.
  3. BoxShadow의 indent도 수정하였습니다.

@Kiboom Kiboom requested a review from yutae February 21, 2020 09:50
@Kiboom
Copy link
Author

Kiboom commented Feb 21, 2020 •
edited

Localhost에서 테스트 하였습니다~ 😀
확인 한 번 더 부탁드립니다🙏

yutae
yutae approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@yutae yutae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 감사합니다 👍

@yutae yutae merged commit fc433e4 into naver:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutae yutae yutae approved these changes

Assignees

@Kiboom Kiboom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kiboom @yutae