Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files from Recycle Bin in Windows #1074

Closed
arg274 opened this issue May 1, 2021 · 12 comments
Closed

Ignore files from Recycle Bin in Windows #1074

arg274 opened this issue May 1, 2021 · 12 comments

Comments

@arg274
Copy link
Contributor

arg274 commented May 1, 2021

Description

Navidrome seems to pick up files from the Recycle Bin in Windows since the folders are not blacklisted.

Expected Behaviour

Ignore any file in Recycle Bin so that trashed files don't appear in ND.

Steps to reproduce

  1. Let ND scan for media files via any of the supported means.

Platform information

  • Operating System: Windows 10 x86_64 binary

Additional information

The folder for recycle bins are usually named $RECYCLE.BIN and are located at the root of a drive. So, if ND is pointed to scan from a root, it will inevitably pick up these folders. Folder name is case-insensitive (i. e. they can be named $Recycle.Bin as well).

@arg274 arg274 added the bug label May 1, 2021
@metalheim
Copy link
Contributor

Would it be feasible to add a file called ".ndignore" in the recycle bin folder?

@arg274
Copy link
Contributor Author

arg274 commented May 1, 2021

Would it be feasible to add a file called ".ndignore" in the recycle bin folder?

I don't think that should be the recommended approach. There might be some hacky solution that I'm not aware of but the Recycle Bin isn't really meant to be a place for users to create files in.

@metalheim
Copy link
Contributor

Agree, Come to think about it, it's a bad idea, even if it worked, it could get easily deleted..

@Uatschitchun
Copy link

Why would one add a system's root as source?

@arg274
Copy link
Contributor Author

arg274 commented May 3, 2021

Why would one add a system's root as source?

Not sure where you're getting that from. Windows keeps recycle bin per partition/drive. It's not an anomaly for me (or anyone using Windows, as a matter of fact) to dedicate one drive to music and point ND towards the root of that drive, especially since ND doesn't support multi-libraries yet.

@JayKaku
Copy link

JayKaku commented May 28, 2021

Description

Navidrome seems to pick up files from the Recycle Bin in Windows since the folders are not blacklisted.

Expected Behaviour

Ignore any file in Recycle Bin so that trashed files don't appear in ND.

Steps to reproduce

  1. Let ND scan for media files via any of the supported means.

Platform information

  • Operating System: Windows 10 x86_64 binary

Additional information

The folder for recycle bins are usually named $RECYCLE.BIN and are located at the root of a drive. So, if ND is pointed to scan from a root, it will inevitably pick up these folders. Folder name is case-insensitive (i. e. they can be named $Recycle.Bin as well).

Apologies for being out of context but could you tell me how exactly did you setup navidrome for windows

@deluan
Copy link
Member

deluan commented May 28, 2021

@JayKaku , it is better to ask this in our Discord channel. Also check the docs for setting up the environment: https://www.navidrome.org/docs/developers/dev-environment/

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Mar 7, 2023
@arg274
Copy link
Contributor Author

arg274 commented Mar 8, 2023

This is still an issue and I still have to empty my bin before doing a Navidrome scan to avoid unintended files from being added, not sure what extra detail to provide.

@github-actions github-actions bot removed the stale label Mar 9, 2023
@deluan deluan closed this as completed in 339a623 Mar 10, 2023
@deluan
Copy link
Member

deluan commented Mar 10, 2023

@arg274 I think I got it. Can you please test it?

@arg274
Copy link
Contributor Author

arg274 commented Mar 10, 2023

@deluan Yep, seems to have fixed it.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants