Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reopen player on demo #1217

Closed
kerenon opened this issue Jun 29, 2021 · 11 comments
Closed

Can't reopen player on demo #1217

kerenon opened this issue Jun 29, 2021 · 11 comments

Comments

@kerenon
Copy link

kerenon commented Jun 29, 2021

After minimizing the "now playing" overlay/window on android, opening it again is almost impossible. It seems the "hitbox" I'd need to find is waaaaay too small. It takes at least 20-30 taps to eventually hit the mark and thus reopening the player overlay, making this a dealbreaker bug.

First noticed the problem a few months ago, found this reddit thread, but no solution:

https://www.reddit.com/r/navidrome/comments/mrf3mn/music_player_bubble_not_clickable_on_demo_app/

What I've written there, still applies except that I have now 2 separate phones with the same issue. It seems the problem only affects chromium based mobile browsers. Firefox and desktop browsers are unaffected.

To make sure none of my addons/adblocking solutions interfere somehow with navidrome, I've done all my tests using a clean browser on an open network. Same result.

@certuna
Copy link
Contributor

certuna commented Jul 6, 2021

I see a related (?) issue with Navidrome in Edge (Chrome probably too, will test):

  • make the window smaller to trigger the mobile view
  • play a song, minimize it to the bubble
  • enlarge the window to switch to desktop view
  • now you can't enlarge the bubble to the bottom-bar player anymore

Issue with the upstream player?

@deluan
Copy link
Member

deluan commented Jul 14, 2021

Issue with the upstream player?

Most probably yes. I'll do some testing. A solution I may implement is to disable the ability to drag the mini-player, as it bring too little value

@deluan deluan closed this as completed in abf6318 Sep 13, 2021
@deluan
Copy link
Member

deluan commented Sep 13, 2021

I made the mini-player position fixed (bottom right of screen), and not draggable anymore. This should help with reopening it. If it does not, please reopen this issue

@deluan
Copy link
Member

deluan commented Sep 20, 2021

The fix has caused responsiveness issues. Reverting :(

@deluan deluan reopened this Sep 20, 2021
@deluan deluan closed this as completed in 892c2bf Sep 20, 2021
@deluan deluan reopened this Sep 20, 2021
@fabpico
Copy link

fabpico commented Jan 6, 2022

I have exactly the same issue (Version: 0.47.0 (8c7d95c1)).

Android chrome: Minimized player can't be opened on tap, only moved around.
Android firefox: Minimized player can be opened
Windows chrome mobile mode: Minimized player can be opened

Workaround is to hard reload the page which opens the big player, but its not handy to do this every time.

I agree with @deluan that moving the minimized player around is not necessary. Spotify also has a fixed variant (bottom bar) as minimized player.

@metalheim
Copy link
Contributor

metalheim commented Jan 6, 2022

I've also experienced this on chrome mobile for Android, but on some devices only. Maybe the event (click) target gets too small on some resolution/dpi combinations?

My pixel 2 has the problem while my galaxy S20 ultra 5g doesn't (same chrome mobile engine version)

EDIT: It's the Galaxy S20 Ultra 5G that I have

@kerenon
Copy link
Author

kerenon commented Jan 6, 2022

My pixel 2 has the problem while my galaxy S20 ultra doesn't (same chrome mobile engine version)

My phone is a Galaxy S20 Ultra 5G, and it has the problem :)

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Mar 7, 2023
@fabpico
Copy link

fabpico commented Mar 7, 2023

Seems to be same as #2043 .

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Sep 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Copy link

github-actions bot commented Feb 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants