Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile player uses 1/4 of available volume level #1429

Closed
mradermaxlol opened this issue Oct 25, 2021 · 10 comments
Closed

Mobile player uses 1/4 of available volume level #1429

mradermaxlol opened this issue Oct 25, 2021 · 10 comments
Labels

Comments

@mradermaxlol
Copy link

mradermaxlol commented Oct 25, 2021

Description

Mobile web player uses the default 25% volume setting, which results in audio playback being far more quiet than it should be. User can't change the 25% value without opening the desktop version.

Expected Behaviour

Mobile web player uses 100% volume setting, as the actual volume is controlled by the OS (media stream). A good alternative is having a volume slider in the mobile version (it's a good question though whether it should control the system media stream or the internal player stream).

Steps to reproduce

  1. Open the mobile web player
  2. Set system media volume to max, play any track
  3. Reload the page as a desktop version, set the volume slider to 100%
  4. Play the same track/return to mobile version and play the same track, notice the difference in volume levels before/after

Platform information

  • Navidrome version: v0.46.0
  • Browser and version: Fennec F-Droid (aka Firefox) 93.1.0; reproducible on other devices with playstore browsers
  • Operating System: Android 11 (Omni); reproducible on other devices with stock e.g. MIUI (various versions)
@XxAcielxX
Copy link

I have the same issue, when using the mobile browser and view is set to portrait mode, there is no way to change volume and also there is no volume button.

Landscape mode has volume button, but it only does mute/unmute.

@srichter
Copy link
Contributor

The upstream player doesn't show the volume slider in the mobile view. One idea would be to show a 3-way toggle button in the mobile player toolbar that toggles between 0%, 50%, and 100% volume.

@deluan
Copy link
Member

deluan commented Oct 27, 2021

Or maybe just set it to 100% and the user uses the device hardware volume?

@srichter
Copy link
Contributor

srichter commented Oct 27, 2021

That was my initial idea, but I couldn't think of an implementation that avoided all cases of "volume surprise." (For instance if we automatically set it to 100% with the mobile player view, if you were using the player in landscape mode and had the volume set to 50%, then rotate to portrait it'd suddenly jump to 100%). We could just set the default to be 100%, but that'd only fix it for devices which don't have the volume state saved locally (Which might not be that big of a downside; clearing storage is easy enough)

@deluan
Copy link
Member

deluan commented Oct 27, 2021

if you were using the player in landscape mode and had the volume set to 50%, then rotate to portrait it'd suddenly jump to 100%

I hope it is just a matter of finding the proper mediaquery for this.

but that'd only fix it for devices which don't have the volume state saved locally

I don't think that's a problem, as you stated...

@XxAcielxX
Copy link

Set it 100% and then control it with hardware volume or maybe somewhere in the settings, so the user can set it him/herself.

@mradermaxlol
Copy link
Author

@deluan any possibility of having this fixed in e.g. 0.47.1?

@deluan deluan closed this as completed in 3e282df Nov 20, 2021
@deluan
Copy link
Member

deluan commented Nov 20, 2021

@mradermaxlol Sorry, I completely forgot about this. I just fixed it, you can try the latest development build. Regarding 0.47.1, I usually only release bug fixes like this if it is a very critical bug, as it creates extra burden on the package maintainers

@mradermaxlol
Copy link
Author

It's alright :) IMO this one is somewhere near the critical level as it cuts listenable volume in half, but worse things happen in life, ha.
Maybe it would make sense to accumulate some fixes and get the .1 version going.

I don't really want to try the development build on my machine, but I guess I could edit the PKGBUILD and cherry-pick the commit.
Thanks a lot!

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants