Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample rate, bit depth, channels, HD audio #1438

Open
3 of 18 tasks
certuna opened this issue Nov 1, 2021 · 4 comments
Open
3 of 18 tasks

Sample rate, bit depth, channels, HD audio #1438

certuna opened this issue Nov 1, 2021 · 4 comments

Comments

@certuna
Copy link
Contributor

certuna commented Nov 1, 2021

This is a placeholder issue for support for various audio (quality) characteristics & how to display them in the UI. There's been plenty of discussion on Discord but no centralized place for implementations.

Serverside

Songs table & API:

  • suffix (file extension)
    Stream info
  • bit_rate
  • channels feat: Adds Audio Channel Metadata - #1036 #1294
  • sample_rate
  • bit_depth
  • codec
  • modulation : PCM or DSD? Worth implementing, or is this already easily inferred from codec?
  • hd : boolean constructed from the values above: true if sample_rate > 44.1k or bit_depth > 16 or modulation = DSD?
  • lossless : currently inferred clientside based on file extension, but should be a boolean in the db/api based on codec
    Tag fields
  • TFLT "File type" : probably not worth implementing, most applications just read this from the stream info
  • TMED "Media type": worth implementing? Maybe not add it to the UI, only as a filter in Smart Playlists?
  • TENC "Encoded by": worth implementing?
  • TSSE "Software/Hardware and settings used for encoding": worth implementing?

Albums table & API:

  • attributes to be rolled up to the album level: hd, lossless, bitrate (highest), channels (highest). We consider an album hd or lossless when it contains HD/Lossless tracks, we don't require all tracks to be: for example, a double album with one HD disc and one non-HD disc counts as HD, a 5.1 album with some 2ch bonus tracks counts as Multichannel

Web UI

  • not implement each attribute with its own column (takes way too much screen space, and not user friendly), but concatenate relevant info in one Quality column, i.e. MP3 320, AAC 5.1, FLAC 96/24
  • new dropdown filter in Songs and Albums view with 5 options: All, High Quality (= 256+ lossy or lossless), Lossless, HD, Multichannel (>2 channels). This to keep the UI clean and intuitive, we can leave more granular filtering for Smart Playlists
  • when hd = true, display a little HD icon behind the song/album title
  • add a toggle in Settings -> Personal "Display audio quality" to show Song Title - MP3 320 in the desktop Now Playing bar, and MP3 320 below the Album Title in the mobile Now Playing screen
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Jul 13, 2023
@certuna
Copy link
Contributor Author

certuna commented Jul 13, 2023

still relevant

@github-actions github-actions bot removed the stale label Jul 14, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2024
@certuna
Copy link
Contributor Author

certuna commented Jan 16, 2024

still relevant

@github-actions github-actions bot removed the stale label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant