Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make artist in song list view clickable #1627

Closed
krateng opened this issue Feb 24, 2022 · 5 comments
Closed

Make artist in song list view clickable #1627

krateng opened this issue Feb 24, 2022 · 5 comments

Comments

@krateng
Copy link

krateng commented Feb 24, 2022

Is your feature request related to a problem? Please describe.

When viewing an album that has songs not by the album artist, the song list shows the individual tracks' artists in the respective column, but I cannot click on them to get to their artist page.

Describe the solution you'd like

In the album view, make the artist column linked to the artist just like in any other song list view.

Thank you!

@awsms
Copy link

awsms commented Apr 20, 2022

I'd add that the current behaviour is extremely unintuitive since artists names are highlighted, but clicking on them plays the tied track instead

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Mar 7, 2023
@awsms
Copy link

awsms commented Mar 7, 2023

Bump as this is not a small issue for a tags-oriented player

@github-actions github-actions bot removed the stale label Mar 8, 2023
@deluan
Copy link
Member

deluan commented Mar 9, 2023

Bump as this is not a small issue for a tags-oriented player

Sorry, but lots of issues with Navidrome are not small issues for a tags-oriented player. I do what I can to keep making it better, as time and life permits.

Anyway, what do you mean by this:

current behaviour is extremely unintuitive since artists names are highlighted

Artists are NOT highlighted if they are not links. In SongList view, only artists that are also AlbumArtists are links:

Screenshot 2023-03-09 at 5 57 57 PM

In this example, "Them" is not a AlbumArtist, all others are and if you click you are redirected to their respective page.

On Album Songs view, this is different. Currently no artists are highlighted/have links there:
Screenshot 2023-03-09 at 6 09 47 PM

I'm changing that and add the same behaviour as in the SongList view:
Screenshot 2023-03-09 at 6 08 12 PM

"Barão Vermelho" now is highlighted and linked to their Artist page.

@deluan deluan closed this as completed in 47f15cc Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants