Downloaded files with slash in tag fields (/) gets converted into new folder

[andylundqvist]

Description

When downloading files from Navidrome 0.47.5 (from an album or playlist), if a tag field contains a "/" character, the download creates a folder at the place of this character in the file name, thus breaking the general, expected file structure.

Example (correct) : A track "Song A" by artist "John" is correctly named "John - Song A.mp3" when downloaded and is placed in the root directory when unzipped.

Example (incorrect): The track "My Track" by artist "Lisa / Michael" when downloaded and unzipped instead gets the filename: "Michael - My track.mp3" inside a folder called "Lisa".

Expected Behaviour

A common solution for such cases is to convert fields with slash ("/") to an underscore ("_") and I believe this would be an easy fix for the problem.

Platform information

• Navidrome version: 0.47.5
• Browser and version: Safari 15.5
• Operating System: macOS 12.4

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

[andylundqvist]

I was unable to comment before the issue was marked stale and closed but I can confirm that this bug still exists in the current 0.49.3 version. Do I need to create a new issue for this?

[deluan]

Thanks for the call-out. I reopened the issue.

[subhajit20]

@deluan hey! I would like to fix this issue also, could you help me like in which file I have to replace the slash with the underscore sign?

[deluan]

This will require a complete dev environment, with make and all. Were you able to install the whole dev environment in your local?

[subhajit20]

This will require a complete dev environment, with make and all. Were you able to install the whole dev environment in your local?

@deluan hey! Yes, I have installed entire environment setup in my local machine.

[subhajit20]

This will require a complete dev environment, with make and all. Were you able to install the whole dev environment in your local?

@deluan Hey thanks for guiding me and it was my first open-source contribution.

[subhajit20]

@deluan and I have made the local setup done can you guide me that which fil do I have to change in this issue ?

[deluan]

Hey @subhajit20 , sorry for the delay.

For this we will need to create a function to clean-up filenames. There maybe something ready on the internets, but we don't want to add a new Go dependency just for that ;)

Then this function will be used in the two places used to add files to a zip:

navidrome/core/archiver.go

Line 89 in c12510d

return fmt.Sprintf("%s/%s", mf.Album, file)

and

navidrome/core/archiver.go

Line 133 in c12510d

file := fmt.Sprintf("%02d - %s - %s.%s", idx+1, mf.Artist, mf.Title, ext)

Don't forget to write tests. Let me know if you have any other questions.

[subhajit20]

@deluan so I have to just paste these two functions you have mentioned above in two separate files or anything else?

[deluan]

You will have to create a function like:

func cleanFilename(name string) string

Then you will use this function in the places I mentioned above. No new files, put this new function in the navidrome/core/archiver.go file.

[andylundqvist]

I haven’t had the time to try it yet but thank you!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.